Skip to content

Add wireshark dissector for baidu_std protocol#2408

Merged
wasphin merged 8 commits into
apache:masterfrom
wasphin:feature/dissector
Oct 17, 2023
Merged

Add wireshark dissector for baidu_std protocol#2408
wasphin merged 8 commits into
apache:masterfrom
wasphin:feature/dissector

Conversation

@wasphin

@wasphin wasphin commented Oct 10, 2023

Copy link
Copy Markdown
Member

What problem does this PR solve?

Issue Number:

Problem Summary:

What is changed and the side effects?

Changed:

Side effects:

  • Performance effects(性能影响): N/A

  • Breaking backward compatibility(向后兼容性): N/A

Check List:

  • Please make sure your changes are compilable(请确保你的更改可以通过编译).
  • When providing us with a new feature, it is best to add related tests(如果你向我们增加一个新的功能, 请添加相关测试).
  • Please follow Contributor Covenant Code of Conduct.(请遵循贡献者准则).

@wasphin wasphin marked this pull request as draft October 10, 2023 15:56
@wasphin

wasphin commented Oct 11, 2023 •
edited
Loading

Copy link
Copy Markdown
Member Author

image

在 wireshark 中勾选后可以使用相关字段进行过滤
image

如： pbf.brpc.StreamFrameMeta.stream_id == 2 过滤指定流。
image

@wasphin wasphin marked this pull request as ready for review October 11, 2023 09:34
@wasphin wasphin changed the title WIP: Add wireshark dissector for baidu_std protocol Add wireshark dissector for baidu_std protocol Oct 11, 2023
@chenBright

chenBright commented Oct 11, 2023

Copy link
Copy Markdown
Contributor

印象中，好像需要将pb文件放到指定位置？

@wasphin

wasphin commented Oct 11, 2023

Copy link
Copy Markdown
Member Author

对，没有统一位置，得用户设置，然后把文件拷过去

@chenBright

chenBright commented Oct 11, 2023

Copy link
Copy Markdown
Contributor

body部分pb的解析，难点在于message不确定和message类型多样，这个能解决吗？

@wasphin

wasphin commented Oct 11, 2023

Copy link
Copy Markdown
Member Author

rpc 部分根据 service name 和 method 应该可以确认 message 类型，streaming 部分不太好处理。

@chenBright

chenBright commented Oct 11, 2023

Copy link
Copy Markdown
Contributor

那可以先将rpc部分实现了

@wasphin

wasphin commented Oct 12, 2023

Copy link
Copy Markdown
Member Author

image
image

@wwbmmm

wwbmmm commented Oct 13, 2023

Copy link
Copy Markdown
Contributor

文件名改成 wireshark_baidu_std.lua 是不是更清晰？另外加个文档说明？

@wasphin

wasphin commented Oct 13, 2023

Copy link
Copy Markdown
Member Author

周末我补个吧

chenBright
chenBright reviewed Oct 16, 2023
View reviewed changes
Comment thread docs/cn/wireshark_baidu_std.md Outdated
@wasphin wasphin closed this Oct 16, 2023
@wasphin wasphin deleted the feature/dissector branch October 16, 2023 03:47
@wasphin wasphin reopened this Oct 16, 2023
@wwbmmm

wwbmmm commented Oct 16, 2023

Copy link
Copy Markdown
Contributor

LGTM

@wasphin wasphin merged commit 12d0728 into apache:master Oct 17, 2023
@AnDiXL AnDiXL mentioned this pull request Jul 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chenBright chenBright chenBright left review comments

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@wasphin @chenBright @wwbmmm